-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #6 from mageplaza/2.4-develop
Clean code
- Loading branch information
Showing
33 changed files
with
1,671 additions
and
1,671 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,34 +1,34 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Technical issue with the extension | ||
| labels: 'Issue' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Preconditions (*) | ||
| <!--- | ||
| Provide the exact Magento version (example: 2.4.0) and any important information on the environment where bug is reproducible. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Steps to reproduce (*) | ||
| <!--- | ||
| Important: Provide a set of clear steps to reproduce this bug. We can not provide support without clear instructions on how to reproduce. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Expected result (*) | ||
| <!--- Tell us what do you expect to happen. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
|
|
||
| ### Actual result (*) | ||
| <!--- Tell us what happened instead. Include error messages and issues. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
| --- | ||
| name: Bug report | ||
| about: Technical issue with the extension | ||
| labels: 'Issue' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Preconditions (*) | ||
| <!--- | ||
| Provide the exact Magento version (example: 2.4.0) and any important information on the environment where bug is reproducible. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Steps to reproduce (*) | ||
| <!--- | ||
| Important: Provide a set of clear steps to reproduce this bug. We can not provide support without clear instructions on how to reproduce. | ||
| --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Expected result (*) | ||
| <!--- Tell us what do you expect to happen. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. | ||
|
|
||
| ### Actual result (*) | ||
| <!--- Tell us what happened instead. Include error messages and issues. --> | ||
| 1. [Screenshots, logs or description] | ||
| 2. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| --- | ||
| name: Developer experience issue | ||
| about: Issues related to customization, extensibility, modularity | ||
| labels: 'Experience' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Summary (*) | ||
| <!--- Describe the issue you are experiencing. Include general information, error messages, environments, and so on. --> | ||
|
|
||
| ### Examples (*) | ||
| <!--- Provide code examples or a patch with a test (recommended) to clearly indicate the problem. --> | ||
|
|
||
| ### Proposed solution | ||
| <!--- Suggest your potential solutions for this issue. --> | ||
| --- | ||
| name: Developer experience issue | ||
| about: Issues related to customization, extensibility, modularity | ||
| labels: 'Experience' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Summary (*) | ||
| <!--- Describe the issue you are experiencing. Include general information, error messages, environments, and so on. --> | ||
|
|
||
| ### Examples (*) | ||
| <!--- Provide code examples or a patch with a test (recommended) to clearly indicate the problem. --> | ||
|
|
||
| ### Proposed solution | ||
| <!--- Suggest your potential solutions for this issue. --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,22 +1,22 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Request feature for development | ||
| labels: 'Feature Request' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Description (*) | ||
| <!--- Describe the feature you would like to add. --> | ||
|
|
||
| ### Expected behavior (*) | ||
| <!--- What is the expected behavior of this feature? How is it going to work? --> | ||
|
|
||
| ### Benefits | ||
| <!--- How do you think this feature would improve the extension? --> | ||
|
|
||
| ### Additional information | ||
| <!--- What other information can you provide about the desired feature? --> | ||
| --- | ||
| name: Feature request | ||
| about: Request feature for development | ||
| labels: 'Feature Request' | ||
|
|
||
| --- | ||
|
|
||
| <!--- | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
|
|
||
| ### Description (*) | ||
| <!--- Describe the feature you would like to add. --> | ||
|
|
||
| ### Expected behavior (*) | ||
| <!--- What is the expected behavior of this feature? How is it going to work? --> | ||
|
|
||
| ### Benefits | ||
| <!--- How do you think this feature would improve the extension? --> | ||
|
|
||
| ### Additional information | ||
| <!--- What other information can you provide about the desired feature? --> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,19 @@ | ||
| <!--- Provide a general summary of the Pull Request in the Title above --> | ||
|
|
||
| ### Description | ||
| <!--- Provide a description of the changes proposed in the pull request --> | ||
|
|
||
| ### Fixed Issues (if relevant) | ||
| <!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant --> | ||
| 1. https://github.com/mageplaza/magento-2-reports/<issue_number>: Issue title | ||
| 2. ... | ||
|
|
||
| ### Manual testing scenarios | ||
| <!--- Provide a set of unambiguous steps to test the proposed code change --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Contribution checklist | ||
| - [ ] Pull request has a meaningful description of its purpose | ||
| - [ ] All commits are accompanied by meaningful commit messages | ||
| - [ ] All new or changed code is covered with unit/integration tests (if applicable) | ||
| <!--- Provide a general summary of the Pull Request in the Title above --> | ||
|
|
||
| ### Description | ||
| <!--- Provide a description of the changes proposed in the pull request --> | ||
|
|
||
| ### Fixed Issues (if relevant) | ||
| <!--- Provide a list of fixed issues in the format magento/magento2#<issue_number>, if relevant --> | ||
| 1. https://github.com/mageplaza/magento-2-reports/<issue_number>: Issue title | ||
| 2. ... | ||
|
|
||
| ### Manual testing scenarios | ||
| <!--- Provide a set of unambiguous steps to test the proposed code change --> | ||
| 1. | ||
| 2. | ||
|
|
||
| ### Contribution checklist | ||
| - [ ] Pull request has a meaningful description of its purpose | ||
| - [ ] All commits are accompanied by meaningful commit messages | ||
| - [ ] All new or changed code is covered with unit/integration tests (if applicable) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,13 @@ | ||
| # Configuration for probot-no-response - https://github.com/probot/no-response | ||
|
|
||
| # Number of days of inactivity before an Issue is closed for lack of response | ||
| daysUntilClose: 7 | ||
| # Label requiring a response | ||
| responseRequiredLabel: waiting-customer-response | ||
| # Comment to post when closing an Issue for lack of response. Set to `false` to disable | ||
| closeComment: > | ||
| This issue has been automatically closed because there has been no response | ||
| to our request for more information from the original author. With only the | ||
| information that is currently in the issue, we don't have enough information | ||
| to take action. Please reach out if you have or find the answers we need so | ||
| that we can investigate further. | ||
| # Configuration for probot-no-response - https://github.com/probot/no-response | ||
|
|
||
| # Number of days of inactivity before an Issue is closed for lack of response | ||
| daysUntilClose: 7 | ||
| # Label requiring a response | ||
| responseRequiredLabel: waiting-customer-response | ||
| # Comment to post when closing an Issue for lack of response. Set to `false` to disable | ||
| closeComment: > | ||
| This issue has been automatically closed because there has been no response | ||
| to our request for more information from the original author. With only the | ||
| information that is currently in the issue, we don't have enough information | ||
| to take action. Please reach out if you have or find the answers we need so | ||
| that we can investigate further. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,57 +1,57 @@ | ||
| <?php | ||
| /** | ||
| * Mageplaza | ||
| * | ||
| * NOTICE OF LICENSE | ||
| * | ||
| * This source file is subject to the Mageplaza.com license that is | ||
| * available through the world-wide-web at this URL: | ||
| * https://www.mageplaza.com/LICENSE.txt | ||
| * | ||
| * DISCLAIMER | ||
| * | ||
| * Do not edit or add to this file if you wish to upgrade this extension to newer | ||
| * version in the future. | ||
| * | ||
| * @category Mageplaza | ||
| * @package Mageplaza_FacebookPlugin | ||
| * @copyright Copyright (c) Mageplaza (https://www.mageplaza.com/) | ||
| * @license https://www.mageplaza.com/LICENSE.txt | ||
| */ | ||
|
|
||
| namespace Mageplaza\FacebookPlugin\Block\Adminhtml\System; | ||
|
|
||
| use Magento\Config\Block\System\Config\Form\Field; | ||
| use Magento\Framework\Data\Form\Element\AbstractElement; | ||
|
|
||
| /** | ||
| * Class Snippet | ||
| * @package Mageplaza\FacebookPlugin\Block\Adminhtml\System | ||
| */ | ||
| class Snippet extends Field | ||
| { | ||
| /** | ||
| * @param AbstractElement $element | ||
| * | ||
| * @return string | ||
| */ | ||
| protected function _getElementHtml(AbstractElement $element) | ||
| { | ||
| $html = '<div class="control-value" style="padding-top: 8px; font-size: 11px"><p>'; | ||
| $html .= __('Use the following code to show facebook plugin in any places which you want.'); | ||
| $html .= '</p><strong>'; | ||
|
|
||
| $html .= __('CMS Page/Static Block'); | ||
| $html .= '</strong><br /><pre style="background-color: #f5f5dc"><code>{{block class="Mageplaza\FacebookPlugin\Block\Widget"}}</code></pre><strong>'; | ||
|
|
||
| $html .= __('Template .phtml file'); | ||
| $html .= '</strong><br /><pre style="background-color: #f5f5dc"><code>' . $this->_escaper->escapeHtml('<?php echo $block->getLayout()->createBlock("\Mageplaza\FacebookPlugin\Block\Widget::class")->toHtml();?>') . '</code></pre><strong>'; | ||
|
|
||
| $html .= __('Layout file'); | ||
| $html .= '</strong><br /><pre style="background-color: #f5f5dc"><code>' . $this->_escaper->escapeHtml('<block class="Mageplaza\FacebookPlugin\Block\Widget" name="fbwidget" />') . '</code></pre>'; | ||
|
|
||
| $html .= '</div>'; | ||
|
|
||
| return $html; | ||
| } | ||
| } | ||
| <?php | ||
| /** | ||
| * Mageplaza | ||
| * | ||
| * NOTICE OF LICENSE | ||
| * | ||
| * This source file is subject to the Mageplaza.com license that is | ||
| * available through the world-wide-web at this URL: | ||
| * https://www.mageplaza.com/LICENSE.txt | ||
| * | ||
| * DISCLAIMER | ||
| * | ||
| * Do not edit or add to this file if you wish to upgrade this extension to newer | ||
| * version in the future. | ||
| * | ||
| * @category Mageplaza | ||
| * @package Mageplaza_FacebookPlugin | ||
| * @copyright Copyright (c) Mageplaza (https://www.mageplaza.com/) | ||
| * @license https://www.mageplaza.com/LICENSE.txt | ||
| */ | ||
|
|
||
| namespace Mageplaza\FacebookPlugin\Block\Adminhtml\System; | ||
|
|
||
| use Magento\Config\Block\System\Config\Form\Field; | ||
| use Magento\Framework\Data\Form\Element\AbstractElement; | ||
|
|
||
| /** | ||
| * Class Snippet | ||
| * @package Mageplaza\FacebookPlugin\Block\Adminhtml\System | ||
| */ | ||
| class Snippet extends Field | ||
| { | ||
| /** | ||
| * @param AbstractElement $element | ||
| * | ||
| * @return string | ||
| */ | ||
| protected function _getElementHtml(AbstractElement $element) | ||
| { | ||
| $html = '<div class="control-value" style="padding-top: 8px; font-size: 11px"><p>'; | ||
| $html .= __('Use the following code to show facebook plugin in any places which you want.'); | ||
| $html .= '</p><strong>'; | ||
|
|
||
| $html .= __('CMS Page/Static Block'); | ||
| $html .= '</strong><br /><pre style="background-color: #f5f5dc"><code>{{block class="Mageplaza\FacebookPlugin\Block\Widget"}}</code></pre><strong>'; | ||
|
|
||
| $html .= __('Template .phtml file'); | ||
| $html .= '</strong><br /><pre style="background-color: #f5f5dc"><code>' . $this->_escaper->escapeHtml('<?php echo $block->getLayout()->createBlock("\Mageplaza\FacebookPlugin\Block\Widget::class")->toHtml();?>') . '</code></pre><strong>'; | ||
|
|
||
| $html .= __('Layout file'); | ||
| $html .= '</strong><br /><pre style="background-color: #f5f5dc"><code>' . $this->_escaper->escapeHtml('<block class="Mageplaza\FacebookPlugin\Block\Widget" name="fbwidget" />') . '</code></pre>'; | ||
|
|
||
| $html .= '</div>'; | ||
|
|
||
| return $html; | ||
| } | ||
| } |
Oops, something went wrong.