Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ActionUpdateThread.OLD_EDT deprecation on DumbAwareActions #2088

Merged

Conversation

piotrkwiecinski
Copy link
Contributor

@piotrkwiecinski piotrkwiecinski commented Jul 10, 2024

Fixes on classes extending DumbAwareAction:

com.intellij.diagnostic.PluginException: `ActionUpdateThread.OLD_EDT` is deprecated and going to be removed soon. 'com.magento.idea.magento2plugin.actions.generation.InjectAViewModelAction' must override `getActionUpdateThread()` and chose EDT or BGT. See ActionUpdateThread javadoc. [Plugin: com.magento.idea.magento2plugin]
	at com.intellij.diagnostic.PluginProblemReporterImpl.createPluginExceptionByClass(PluginProblemReporterImpl.java:23)
	at com.intellij.diagnostic.PluginException.createByClass(PluginException.java:90)
	at com.intellij.diagnostic.PluginException.reportDeprecatedUsage(PluginException.java:125)
	at com.intellij.openapi.actionSystem.ActionUpdateThreadAware.getActionUpdateThread(ActionUpdateThreadAware.java:21)
	at com.intellij.openapi.actionSystem.AnAction.getActionUpdateThread(AnAction.java:199)
  1. Fixes Bug Report 2024/07/10 #2083
  2. Fixes Bug Report 2024/07/10 #2084
  3. Fixes Bug Report 2024/07/10 #2085
  4. Fixes Bug Report 2024/07/10 #2086
  5. Fixes Bug Report 2024/07/12 #2089

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with integration/functional tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@piotrkwiecinski piotrkwiecinski marked this pull request as ready for review July 10, 2024 15:52
@VitaliyBoyko VitaliyBoyko merged commit ac57672 into magento:5.3.0-develop Jul 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants