Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge PR. Use this one when You need to merge magento2ce & magento2ee #360

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vgoncharenko
Copy link
Contributor

@vgoncharenko vgoncharenko commented Sep 29, 2020

Description (*)

Related Pull Requests

magento/magento2#30279
https://github.com/magento/partners-magento2ee/pull/359

Fixed Issues (if relevant)

  1. Fixes magento/catalog-storefront#<issue_number>

Questions or comments

Code Review Checklist (*)

See dataied checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatibile changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

@vgoncharenko
Copy link
Contributor Author

@magento run Functional Tests EE

@mslabko
Copy link
Member

mslabko commented Sep 29, 2020

@magento run WebAPI Tests

@mslabko
Copy link
Member

mslabko commented Sep 29, 2020

@magento run Functional Tests EE
without extensions magento/adobe-stock-integration, magento/security-package, magento/magento2-page-builder, magento/magento2-page-builder-ee, magento/adobe-ims

@mslabko
Copy link
Member

mslabko commented Sep 30, 2020

magento/magento2#30245

@vgoncharenko
Copy link
Contributor Author

@magento run Functional Tests EE
without extensions magento/adobe-stock-integration, magento/magento2-page-builder, magento/magento2-page-builder-ee, magento/adobe-ims

@vgoncharenko
Copy link
Contributor Author

@magento run all tests

@vgoncharenko
Copy link
Contributor Author

SVC and Static tests failures are expected - changes in magento

@vgoncharenko
Copy link
Contributor Author

@magento run Integration Tests

@vgoncharenko
Copy link
Contributor Author

vgoncharenko commented Oct 1, 2020

error doesn't look good on Integration tests (Magento\Setup\Console\Command\GenerateFixturesCommandTest
):

Product Feed index process unknown error:
SQLSTATE[HY000]: General error: 2006 MySQL server has gone away
Sales Rule index process unknown error:
SQLSTATE[HY000]: General error: 2006 MySQL server has gone away

Base automatically changed from develop to main February 8, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants