Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigurableWishlistItem.child_sku throws an internal error if customer wishlist has un-configured configurable product #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bubasuma
Copy link

@bubasuma bubasuma commented Feb 9, 2022

Problem

ACP2E-267: GraphQl - Issues with add Configurable product to Wishlist

[2022-01-27T01:13:07.037742+00:00] report.ERROR: Call to a member function getProduct() on null

GraphQL (20:13)
19:           ... on ConfigurableWishlistItem  {
20:             child_sku
                ^
21:             customizable_options {

Solution

Deprecate ConfigurableWishlistItem.child_sku and add a new field ConfigurableWishlistItem.configured_variant that returns child product details (ProductInterface ) or NULL if the child product is not configured

Requested Reviewers

@cpartica

@bubasuma bubasuma changed the title ACP2E-267: GraphQl - Issues with add Configurable product to Wishlist ConfigurableWishlistItem.child_sku throws an internal error if customer wishlist has un-configured configurable product Feb 9, 2022
Copy link
Member

@larsroettig larsroettig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants