Update binding flags, and pick the correct httprequest class #62
Conversation
Tatsujinichi
changed the title
|
@nullorvoid can you review this |
|
Logic looks fine, no problem with this, but it will need to be tested on 5.5.3 before I will merge it. Would you mind doing this? I can do this, but at the earliest will be Tuesday next week |
| @@ -131,8 +132,8 @@ public void SetupModules(List<string> moduleNames, Action<Exception> cb) | |||
| { | |||
| if (moduleName == t.Name) | |||
| { | |||
| BindingFlags staticProperty = BindingFlags.Static | BindingFlags.GetProperty; | |||
| BindingFlags publicMethod = BindingFlags.Public | BindingFlags.InvokeMethod; | |||
| BindingFlags staticProperty = BindingFlags.InvokeMethod | BindingFlags.GetField | BindingFlags.GetProperty; | |||
There was a problem hiding this comment.
Provided these flag changes work on all devices, LGTM 👍
|
@Tatsujinichi why some of the lines showing as changed although they're not Other than above comments LGMT 👍 |
|
I assume my editor was converting spaces to tabs, but I could be wrong. |
|
@Tatsujinichi |
|
Yes, it was line endings. I believe the LF is the correct ending. |
|
👍 |
|
Actually I am not sure the unity version of httprequest is working at all. I've switched back to the .net version. |
|
We should probably move it from WWW to UnityWebRequest which is much newer and probably better supported. |
|
closing this as #66 should accomplish the same thing |
For Issue
BindingFlags and Invoke Member Unity 2017.1 #61
not tested on earlier versions of unity,
works on 2017.1.0f3