Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cleanup #37

Merged
merged 7 commits into from
Jun 9, 2016
Merged

Feature/cleanup #37

merged 7 commits into from
Jun 9, 2016

Conversation

kefniark
Copy link
Collaborator

@kefniark kefniark commented Jun 3, 2016

Description

  • Add namespaces (change the folder structure)
  • Linting and remove bunch of warnings (Visual Studio & Resharper are our friends)
  • Add lot of null check

Few open issues are probably concerned by this PR #5 #7 #14 #18 #19

P.S. This PR move and rename lot of method, updating from a previous version is not smooth and need some modules modifications

TODO Later

  • Remove usage of reflection for the module instantiation
  • Remove the async class, we can do without (current usage are limitated and need to be rewritten anyway)
  • Change the event emitter to use proper c# event

@kefniark kefniark changed the title WIP: Feature/cleanup Feature/cleanup Jun 6, 2016
@kefniark kefniark mentioned this pull request Jun 6, 2016
@MiLk
Copy link
Collaborator

MiLk commented Jun 6, 2016

It would be a good idea to start doing release and creating tags on this project.
It would avoid breaking projects when the API changes.

@nullorvoid
Copy link
Contributor

At the moment it looks like this is a per project branch structure, but at some point we should start tagging and releasing them I agree. @ronkorving @AlmirKadric do we have a path to go down to start doing this?

@ronkorving
Copy link
Member

What do you mean by "a path"? Just tag em and bag em :) Anyone willing to take responsible ownership can be a release manager.

@christopherobin
Copy link
Collaborator

You'll want to port the latest changes made by @AlmirKadric in his PR #35 especially the bits about headers and cookies

@kefniark
Copy link
Collaborator Author

kefniark commented Jun 9, 2016

Yes, we are planning with @nullorvoid to rewrite this network part and make it testable. So I will backport the last PRs at that time (ipv6, header, cookies,...)

namespace Wizcorp.MageSDK.Editor
{
[InitializeOnLoad]
public static class UnityEditorPlayMode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice for some docs on this

@nullorvoid
Copy link
Contributor

I'm ok with merging this PR to get things moving (it's not against develop) @AlmirKadric @ronkorving

@nullorvoid nullorvoid merged commit 941accb into mage:coj-dev Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants