-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/cleanup #37
Feature/cleanup #37
Conversation
It would be a good idea to start doing release and creating tags on this project. |
At the moment it looks like this is a per project branch structure, but at some point we should start tagging and releasing them I agree. @ronkorving @AlmirKadric do we have a path to go down to start doing this? |
What do you mean by "a path"? Just tag em and bag em :) Anyone willing to take responsible ownership can be a release manager. |
You'll want to port the latest changes made by @AlmirKadric in his PR #35 especially the bits about headers and cookies |
Yes, we are planning with @nullorvoid to rewrite this network part and make it testable. So I will backport the last PRs at that time (ipv6, header, cookies,...) |
namespace Wizcorp.MageSDK.Editor | ||
{ | ||
[InitializeOnLoad] | ||
public static class UnityEditorPlayMode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice for some docs on this
I'm ok with merging this PR to get things moving (it's not against develop) @AlmirKadric @ronkorving |
Description
Few open issues are probably concerned by this PR #5 #7 #14 #18 #19
P.S. This PR move and rename lot of method, updating from a previous version is not smooth and need some modules modifications
TODO Later