[MNOE-909]Removed trackable for impersonation requests #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouranos
requested changes
Feb 8, 2018
| @@ -39,6 +40,10 @@ def destroy | |||
|
|
|||
| private | |||
|
|
|||
| def skip_trackable | |||
There was a problem hiding this comment.
This part is not needed, the function is already defined in the ApplicationController
There was a problem hiding this comment.
@ouranos
Ah I see.
I'm a little confused as to why this is in the application_controller. Trackables are only updated when the user signs in, correct? I see several before_filter :authenticate_user!, does it have to do with that?
There was a problem hiding this comment.
Sorry this was added in #578 and hasn't made to the 4.0 branch yet.
The method is in the ApplicationController so it can be called from any controller that might requires it.
Added more details in JIRA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devise makes it easy to skip trackable. Just need to set request.env["devise.skip_trackable"] = true, BEFORE authentication happens. Tested locally and works.
It is appropriate to put it in the impersonate_controller, rather than the general auth-controller because we specifically want to do this on impersonating.
If we wanted to skip trackable other times, we could consider moving it into
sessions_controller.rband having anif params[:skip_trackable].