Mnoe dev toolkit #261
Mnoe dev toolkit #261
Conversation
Adjusted and improved the dev workspace to use mno-enterprise devise to authenticate impac-angular, and use the new Impac! JPI.
This allows for the placeholder with important information to be shown.
|
|
| return _self._defaults = angular.copy(DEFAULTS); | ||
| } | ||
|
|
||
| // NOTE: this will be refactored a lot when mnoe routes are added as default |
There was a problem hiding this comment.
Indeed -> isn't it a good occasion to do it? :)
Looks like you've done 80% of the work below...
Remove proxy, config angular devise for cors as default
|
@ouranos please review the "Merge pull request #6 from xaun/remove-proxy" changes to see my working solution for providing CSRF support for the Dev Toolkit! So you were right, Angular does not apply the CSRF token to CORS requests. Took a bit of work to figure out the best way to apply this, and once I did that, I realised that the CSRF token gets refreshed on various Angular Devise methods, so I had to come up with a little service to manage that. @cesar-tonnoir FYI & not ready for merge. Related PRs: Remaining works:
|
|
Reviewed: https://github.com/xaun/impac-angular/pull/6 |
|
@xaun is there anything preventing you from merging this PR? |
xaun
dismissed
cesar-tonnoir’s stale review
Changes have now been approved @ouranos
@cesar-tonnoir please review - not ready for merge though. I need to update the developer docs, which I will do once @ouranos get's back to me about CORS so I can commit & document the uat urls in default settings. 🍻