Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Widget] [Accounts comparison] Selected accounts list is cleared upon company selection / checkbox ticking #6

Open
cesar-tonnoir opened this issue Nov 3, 2015 · 1 comment
Open

[Widget] [Accounts comparison] Selected accounts list is cleared upon company selection / checkbox ticking #6

cesar-tonnoir opened this issue Nov 3, 2015 · 1 comment
Assignees
@xaun
Labels
bug

Comments

@cesar-tonnoir
Copy link
Contributor

Instead of completely clearing the accounts list, we should keep in the list the accounts that have previously been selected, and that match the new criteria.

Example:

Given that I have only "CompanyA" enabled, and I have selected "Account1" and "Account2",
When I enable "CompanyB"
Then it should keep "CompanyA - Account1" and "CompanyA - Account2" in the selection list

Other example:

Given that I have "CompanyA" and "CompanyB" selected, in "compare matching accounts" mode, with "Account1" selected
When I untick the checkbox,
Then it should keep "CompanyA - Account1" and "CompanyB - Account1" in the selection list

See the idea @xaun ?
This was referenced Nov 11, 2015
Merged
Merged
@cesar-tonnoir cesar-tonnoir changed the title Accounts comparison - selected accounts list is cleared upon company selection / checkbox ticking [Widget] [Accounts comparison] Selected accounts list is cleared upon company selection / checkbox ticking Nov 24, 2015
@cesar-tonnoir
Copy link
Contributor Author

https://maestrano.atlassian.net/browse/IMPAC-56

@xaun xaun mentioned this issue Nov 16, 2016
Merged
xaun added a commit that referenced this issue Nov 25, 2016
@xaun
Merge pull request #6 from xaun/remove-proxy
b2404fc 
Remove proxy, config angular devise for cors as default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xaun xaun

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xaun @cesar-tonnoir