add a type annotation to constructor. #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the return type to the constructor. This does not affect runtime behavior but helps users of this package who are using a strict typechecker like `mypy --strict`.
|
Just so you're aware it looks like python-json-logger is currently unmaintained, that said I am working on a maintained fork |
|
Thanks @nhairs! I voted on your open issue. I hope you get your request approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies for such a fussy, small change. This does not affect runtime behavior but helps users of this package who are using a strict typechecker like
mypy --strict. I hope you will consider it.