Fix error when passing a rename field that does not exist in the log record #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhenckel
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
The suggested changes allow for a more flexible use of the rename_fields parameter in the jsonlogger.
In fact, it increases the robustness of the implementation of rename_fields, since it removes the need for the assumption that the fields are always present in the log_record.
To my knowledge, the suggested changes does not break backwards compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #171.
Added an exists check for the old_field_name before asigning a value to log_record[new_field_name].