Remove no_dead_strip marks
#670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
reviewed
Nov 16, 2024
There was a problem hiding this comment.
I honestly still feel like I understand this too little. For example, why do the regular part get stripped from the final binary?
Also not too sure about removing them from the image info / module info, from what I understand image info is kinda important for letting the (dynamic? can't remember which one, if not both) linker know that it should translate Objective-C sections.
Berrysoft
force-pushed
the
fix/remove-no-dead-strip
branch
from
58ed263
to
2e98c41
Compare
|
OK, you're right. I choose to remove |
Berrysoft
force-pushed
the
fix/remove-no-dead-strip
branch
from
2e98c41
to
3ef04f0
Compare
madsmtm
approved these changes
Nov 16, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #667
I think there won't be a person to explain why objc ABI 2 uses
no_dead_stripin a short time. Maybe it is better to remove it first. If there were more problems, we would know why it is necessary:)