fix: test fixes on x86 (32bit) architecture #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following warning on 32-bits architectures:
In file included from ../lib/container_docker_count.c:44,
from tslibcontainer_docker_count.c:33:
../lib/container_docker_count.c: In function 'docker_running_containers':
../include/logging.h:28:44: warning: format '%lu' expects argument of type 'long unsigned int',
but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
28 | # define dbg(format, ...) fprintf (stdout, "DEBUG: " format, ##__VA_ARGS__)
| ^~~~~~~~~
../lib/container_docker_count.c:213:3: note: in expansion of macro 'dbg'
213 | dbg ("%lu bytes retrieved\n", chunk.size);
| ^~~
Signed-off-by: Davide Madrisan <[email protected]>
On Gentoo Base System release 2.14 for 32-bits (unsigned long)(6.26*100) = 625 So the test fails. As a workaround modify the data file used by the test. Signed-off-by: Davide Madrisan <[email protected]>
Fix the following errors:
1) check function sizetollint with arg 1024b ... OK
2) check function sizetollint with arg 8k ... OK
3) check function sizetollint with arg 50m ... OK
4) check function sizetollint with arg 2g ... OK
5) check function sizetollint with arg 3t ... FAILED
6) check function sizetollint with arg 2p ... FAILED
7) check function sizetollint with arg 1024B ... OK
8) check function sizetollint with arg 8K ... OK
9) check function sizetollint with arg 50M ... OK
10) check function sizetollint with arg 2G ... OK
11) check function sizetollint with arg 3T ... FAILED
12) check function sizetollint with arg 2P ... FAILED
The long int is not large enough on 32-bit architectures.
Signed-off-by: Davide Madrisan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.