Add a 'quote' attribute to generate quoted TS properties #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TypeScript it is possible to have interfaces with fields that are not valid JS identifiers, if they are enclosed in quotes. If you use the current version of tsify with
#[serde(rename)]
, it can produce interfaces with these properties, but in most cases it does not enclose them with quotes (unless they contain a-
, with current logic).One approach to fixing this is to enhance the logic for automatically detecting whether a property is a valid JS identifier. Since this is defined with a relatively large category of Unicode characters, the easiest way to do this would be to take a dependency on a crate such as unicode-ident.
I figured a simpler way was to give the crate user an escape hatch in the form of a new attribute
quote
which will enclose the resulting TS field in quotes.Closes #37