Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various issues with HRDCOD=0 and HRDCOD=1 builds of no_b_mass and loop_no_b_mass SM processes #695

Closed
valassi opened this issue Jun 13, 2023 · 5 comments
Assignees

Comments

@valassi
Copy link
Member

valassi commented Jun 13, 2023

Add support for HRDCOD=0 builds of no_b_mass SM processes

Presently these processes fail the build like non-SM processes. The problem, as usual, is the handling of parameter dependencies.

For instance in ttW (which I just added as suggested by Francesco Giuli in ATLAS):

[avalassi@itscrd80 gcc11.2/cvmfs] /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/pp_ttW.sa/SubProcesses/P0_Sigma_loop_sm_no_b_mass_dux_ttxwm> make 
...
Building in BUILDDIR=. for tag=512y_d_inl0_hrd0_hasCurand (USEBUILDDIR is not set)
make -C ../../src  -f cudacpp_src.mk
make[1]: Entering directory '/data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/pp_ttW.sa/src'
AVX=512y
ccache /cvmfs/sft.cern.ch/lcg/releases/gcc/11.2.0-ad950/x86_64-centos8/bin/g++  -O3  -std=c++17 -I.  -fPIC -Wall -Wshadow -Wextra -ffast-math  -fopenmp -march=skylake-avx512 -mprefer-vector-width=256  -DMGONGPU_FPTYPE_DOUBLE -DMGONGPU_FPTYPE2_DOUBLE -c Parameters_loop_sm_no_b_mass.cc -o Parameters_loop_sm_no_b_mass.o
In file included from Parameters_loop_sm_no_b_mass.cc:15:
Parameters_loop_sm_no_b_mass.h:26:2: error: #error This non-SM physics process only supports MGONGPU_HARDCODE_PARAM builds (#439): please run "make HRDCOD=1"
   26 | #error This non-SM physics process only supports MGONGPU_HARDCODE_PARAM builds (#439): please run "make HRDCOD=1"
      |  ^~~~~
@valassi
Copy link
Member Author

valassi commented Jun 13, 2023

The process is

    pp_ttW)
      cmd="import model loop_sm-no_b_mass
      define p = p b b~
      define j = p
      define w = w+ w- # W case only
      generate p p > t t~ w @0
      add process p p > t t~ w j @1"
      ;;

@valassi
Copy link
Member Author

valassi commented Jun 13, 2023

Note, this affects ALL no_b_mass SM processes - including other ATLAS processes like #673

valassi added a commit to valassi/madgraph4gpu that referenced this issue Jun 13, 2023
valassi added a commit to valassi/madgraph4gpu that referenced this issue Jun 13, 2023
@valassi valassi changed the title Add support for HRDCOD=0 builds of no_b_mass SM processes Add support for HRDCOD=0 builds of no_b_mass and loop_no_b_mass SM processes Jul 21, 2023
@valassi
Copy link
Member Author

valassi commented Jul 21, 2023

I have renamed this to mention that BOTH no_b_mass and loop_no_b_mass processes are affected for HRDCOD=0.

Conversely, for HRDCOD=1, only loop_no_b_mass processes cannot be built (#696), while no_b_mass can be built (MR #706), although they currently fail at runtime (#733).

@valassi
Copy link
Member Author

valassi commented Nov 25, 2023

I have renamed this to mention that BOTH no_b_mass and loop_no_b_mass processes are affected for HRDCOD=0.

Conversely, for HRDCOD=1, only loop_no_b_mass processes cannot be built (#696), while no_b_mass can be built (MR #706), although they currently fail at runtime (#733).

The first statement is now wrong. I am not sure if something changed, or most likely I was confused when I wrote it.

I confirm that nobm_pp_ttW.mad builds ok also for HRDCOD=0 (and, not surprisingly, for HRDCOD=1 too). See the upcoming MR #706. So there is no problem with nobm models, there is only a problem with loop_nobm models.

I will rename this issue, again.

@valassi valassi changed the title Add support for HRDCOD=0 builds of no_b_mass and loop_no_b_mass SM processes Add support for HRDCOD=0 builds of loop_no_b_mass SM processes Nov 25, 2023
valassi added a commit to valassi/madgraph4gpu that referenced this issue Nov 25, 2023
NB1: the code builds ok for HRDCOD=0 (so madgraph5#695 does NOT affect this!), and runTest is ok in all P* (the ref files are there)

NB2: a full tlau test is now also ok on this process, showing that all issues madgraph5#701 madgraph5#733 madgraph5#783 etc have been fixed

tlau/lauX.sh -CPP nobm_pp_ttW.mad
...
     Cross-section :   1.276 +- 0.007916 pb

In summary: this process should now be fully usable by ATLAS and other experiments.
@valassi
Copy link
Member Author

valassi commented Mar 20, 2024

I think that this issue was mixing too many things, HRDCOD=0 and HRDCOD=1, and no_b_mass and loop_no_b_mass.

The no_b_mass builds of pp_ttW are fixed after a long debugging (FPEs etc), for both HRDCOD=0 and HRDCOD=1.

There are a few issues remaining specifically for loop_no_b_mass instead (COND and reglog), but these are better followed up in #696.

I close this one for simplicity and I rename it.

@valassi valassi closed this as completed Mar 20, 2024
@valassi valassi self-assigned this Mar 20, 2024
@valassi valassi changed the title Add support for HRDCOD=0 builds of loop_no_b_mass SM processes Various issues with HRDCOD=0 and HRDCOD=1 builds of no_b_mass and loop_no_b_mass SM processes Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant