Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(l1_receipt): trimmed hash #470

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(l1_receipt): trimmed hash #470

wants to merge 2 commits into from
+13 −1

Conversation

Trantorian1
Copy link
Collaborator

Pull Request type

  • Bugfix

What is the current behavior?

Resolves: #469

What is the new behavior?

Correctly converts the H256 message hash of an L1HandlerTransactionReceipt to a String.

Does this introduce a breaking change?

No.

@Trantorian1 Trantorian1 added the bug Report an issue or unexpected behavior label Jan 20, 2025
@Trantorian1 Trantorian1 self-assigned this Jan 20, 2025
apoorvsadana
apoorvsadana reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@apoorvsadana apoorvsadana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this quick PR! Should we add a test case/modify an existing one to be able to catch this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoorvsadana apoorvsadana apoorvsadana left review comments

@jbcaron jbcaron jbcaron approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@Trantorian1 Trantorian1

Labels
bug Report an issue or unexpected behavior
Projects
Madara
Status: In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(l1_receipt): trimmed hash
3 participants
@Trantorian1 @apoorvsadana @jbcaron