Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZSH - changed dependancy pcre->pcre2 since pcre is not compiling #26023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ZSH - changed dependancy pcre->pcre2 since pcre is not compiling #26023

wants to merge 1 commit into from
+1 −1

Conversation

Behinder
Copy link

Description

Type(s)
  • [ X] bugfix
  • enhancement
  • security fix
Tested on

@macportsbot
Copy link

Notifying maintainers:
@larryv for port zsh.

reneeotten
reneeotten requested changes Sep 30, 2024
View reviewed changes
shells/zsh/Portfile
@@ -21,7 +21,7 @@ homepage https://www.zsh.org
depends_lib port:gdbm \
port:libiconv \
port:ncurses \
port:pcre
port:pcre2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing a library dependency requires a "revision" increase.

@reneeotten
Copy link
Contributor

and your commit message doesn't follow our guidelines. It should be ": short description"; the port name isn't capitalized either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reneeotten reneeotten reneeotten requested changes

Assignees

@larryv larryv

Labels
maintainer: requires approval
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Behinder @macportsbot @reneeotten @larryv