Version 12.2.2 (#382)

When toolbar item is clicked, first pop the route and then call its callback - Fixes #346 (#381) * fix: when a toolbar item is clicked, remove route first and then call its callback - fixes #346 * chore: update version and changelog Co-authored-by: Minas Giannekas <[email protected]>
macosui · Mar 3, 2023 · 278dc11 · 278dc11
1 parent dd76d06
commit 278dc11
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## [1.12.2]
+* Fixed a bug where clicking on a overflowed toolbar item with a navigation callback wouldn't work ([#346](https://github.com/GroovinChip/macos_ui/issues/346)).
+
 ## [1.12.1+1]
 * Fixed a typo in the December abbreviation displayed in the `MacosDatePicker`.
 

diff --git a/example/pubspec.lock b/example/pubspec.lock
@@ -97,7 +97,7 @@ packages:
       path: ".."
       relative: true
     source: path
-    version: "1.12.1+1"
+    version: "1.12.2"
   matcher:
     dependency: transitive
     description:

diff --git a/lib/src/layout/toolbar/toolbar_overflow_menu_item.dart b/lib/src/layout/toolbar/toolbar_overflow_menu_item.dart
@@ -54,8 +54,8 @@ class _ToolbarOverflowMenuItemState extends State<ToolbarOverflowMenuItem> {
   }
 
   void _handleOnTap() {
-    widget.onPressed?.call();
     Navigator.pop(context);
+    widget.onPressed?.call();
   }
 
   bool get _isHighlighted => _isHovered || widget.isSelected == true;

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,6 +1,6 @@
 name: macos_ui
 description: Flutter widgets and themes implementing the current macOS design language.
-version: 1.12.1+1
+version: 1.12.2
 homepage: "https://macosui.dev"
 repository: "https://github.com/GroovinChip/macos_ui"