Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ensure that status codes are checked in any case #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: ensure that status codes are checked in any case #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions graphql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ func (c *Client) runWithJSON(ctx context.Context, req *Request, resp interface{}
return errors.Wrap(err, "reading body")
}
c.logf("<< %s", buf.String())
bodyStr := buf.String()

if err := json.NewDecoder(&buf).Decode(&gr); err != nil {
if res.StatusCode != http.StatusOK {
return fmt.Errorf("graphql: server returned a non-200 status code: %v", res.StatusCode)
Expand All @@ -147,6 +149,17 @@ func (c *Client) runWithJSON(ctx context.Context, req *Request, resp interface{}
// return first error
return gr.Errors[0]
}

// Handle the http status codes before handling response from the graphql endpoint.
// If this is not done then !200 status codes will just be ignored without the caller even noticing, instead
// the caller just gets back an empty result set, suggesting that the query did not found any result.
// The reason for this is that for example in case of a 404,401,403 etc. the request is rejected before
// it even hits an graphql handler on the server side.
// As a result the response returned by this non graphql component is not compliant to the graphql spec.
if res.StatusCode != http.StatusOK {
return fmt.Errorf("graphql: server returned a non-200 status code: %v - %v", res.StatusCode, bodyStr)
}

return nil
}

Expand Down Expand Up @@ -208,6 +221,8 @@ func (c *Client) runWithPostFields(ctx context.Context, req *Request, resp inter
return errors.Wrap(err, "reading body")
}
c.logf("<< %s", buf.String())
bodyStr := buf.String()

if err := json.NewDecoder(&buf).Decode(&gr); err != nil {
if res.StatusCode != http.StatusOK {
return fmt.Errorf("graphql: server returned a non-200 status code: %v", res.StatusCode)
Expand All @@ -218,6 +233,16 @@ func (c *Client) runWithPostFields(ctx context.Context, req *Request, resp inter
// return first error
return gr.Errors[0]
}

// Handle the http status codes before handling response from the graphql endpoint.
// If this is not done then !200 status codes will just be ignored without the caller even noticing, instead
// the caller just gets back an empty result set, suggesting that the query did not found any result.
// The reason for this is that for example in case of a 404,401,403 etc. the request is rejected before
// it even hits an graphql handler on the server side.
// As a result the response returned by this non graphql component is not compliant to the graphql spec.
if res.StatusCode != http.StatusOK {
return fmt.Errorf("graphql: server returned a non-200 status code: %v - %v", res.StatusCode, bodyStr)
}
return nil
}

Expand Down