Fixed mod function #7

wilson1yan · 2016-09-28T20:08:17Z

I've fixed the mod(a,b) function implementation

stefanv · 2016-09-28T20:10:37Z

calc/__init__.py

@@ -14,8 +14,8 @@ def mul(a, b):
    return b

 def mod(a, b):
-    res = a % b
-    return -1
+	"""Return the mod of 2 integers"""


This indentation is incorrect (should be 4 spaces)

stefanv · 2016-09-28T20:16:49Z

calc/tests/test_calc.py

@@ -3,3 +3,5 @@
 def test_add():
    assert add(1, 2) == 3

+def test_mod():
+	assert mod(5,2) == 1


Incorrect indentation

stefanv · 2016-09-28T20:18:24Z

Please rebase on master

stefanv · 2016-09-29T06:31:17Z

calc/tests/test_calc.py

+
+def test_mod():
+	assert mod(5,2) == 1


Incorrect indentation.

Please ensure editor is set to indent with 4 spaces.

stefanv reviewed Sep 28, 2016

View reviewed changes

wy12345 added 4 commits September 28, 2016 13:29

Fixed the mod function implementation

be1f728

Fixed indentation build error

abfe214

Added tests for mod function

6a620d4

Fixed indentation

0893b57

wilson1yan force-pushed the update_mod branch from 0af23aa to 0893b57 Compare September 28, 2016 20:31

stefanv reviewed Sep 29, 2016

View reviewed changes

Provide feedback