This repository has been archived by the owner on Dec 9, 2022. It is now read-only.
Fix README example to not run workflow on delete #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great tool here! Integrated it this morning into my own project and was surprised how easy and effective it is.
One thing that I noticed in my trials: the example in the README will run the workflow for both creation & deletion of a comment containing a trigger phrase. This seems like it would be (more often than not) undesirable for most use cases.
Looking into it more, I saw that the issue_comment workflow event has
created,edited, anddeletedtypes. Proposing this small change to the demo to help the next person become immediately aware that they can explicitly limit the runs to creation only.Thanks again for such a great tool!