Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct typo. #2

Open
wants to merge 2 commits into
base: 8.x-1.x
Choose a base branch
from
Open

Correct typo. #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7966c40
Fixes typo.
fjgarlin May 4, 2018
dfe17fd
Added quotes on both sides.
fjgarlin Jun 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ExpressionHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function getFieldExpressions($entityTypeId) {
// We're hardcoding this here as the API does not expose this.
$sqlColumn = "{$fieldName}_{$column}";
// @todo Better use field storage definitions.
$sqlValue = (is_int($value) || is_float($value)) ? (string) $value : "'$value";
$sqlValue = (is_int($value) || is_float($value)) ? (string) $value : "'$value'";
// Revision table expressons get silently ignored if not applicable.
$sqlTables = ["{$entityTypeId}__{$fieldName}", "{$entityTypeId}_revision__{$fieldName}"];
foreach ($sqlTables as $sqlTable) {
Expand Down