Merge pull request privacy-scaling-explorations#1517 from privacy-sca…

…ling-explorations/fix/circuits fix(circuits): ensure we check index < numSignups
mabsattar · May 30, 2024 · 926282a · 926282a
2 parents ee28c20 + adeb6b8
commit 926282a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/circuits/circom/utils/non-qv/messageValidator.circom b/circuits/circom/utils/non-qv/messageValidator.circom
@@ -48,10 +48,10 @@ template MessageValidatorNonQv() {
     signal output isValid;
 
     // Check (1) - The state leaf index must be valid.
-    // The check ensure that the stateTreeIndex <= numSignUps as first validation.
-    // Must be <= because the stateTreeIndex is 1-based. Zero is for blank state leaf
-    // while 1 is for the first actual user matching the numSignUps start.
-    var computedIsStateLeafIndexValid = SafeLessEqThan(252)([stateTreeIndex, numSignUps]);
+    // The check ensure that the stateTreeIndex < numSignUps as first validation.
+    // Must be < because the stateTreeIndex is 0-based. Zero is for blank state leaf
+    // while 1 is for the first actual user.
+    var computedIsStateLeafIndexValid = SafeLessThan(252)([stateTreeIndex, numSignUps]);
 
     // Check (2) - The max vote option tree index must be correct.
     var computedIsVoteOptionIndexValid = SafeLessThan(252)([voteOptionIndex, maxVoteOptions]);

diff --git a/circuits/circom/utils/qv/messageValidator.circom b/circuits/circom/utils/qv/messageValidator.circom
@@ -48,10 +48,10 @@ template MessageValidator() {
     signal output isValid;
 
     // Check (1) - The state leaf index must be valid.
-    // The check ensure that the stateTreeIndex <= numSignUps as first validation.
-    // Must be <= because the stateTreeIndex is 1-based. Zero is for blank state leaf
-    // while 1 is for the first actual user matching the numSignUps start.
-    var computedIsStateLeafIndexValid = SafeLessEqThan(252)([stateTreeIndex, numSignUps]);
+    // The check ensure that the stateTreeIndex < numSignUps as first validation.
+    // Must be < because the stateTreeIndex is 0-based. Zero is for blank state leaf
+    // while 1 is for the first actual user.
+    var computedIsStateLeafIndexValid = SafeLessThan(252)([stateTreeIndex, numSignUps]);
 
     // Check (2) - The max vote option tree index must be correct.
     var computedIsVoteOptionIndexValid = SafeLessThan(252)([voteOptionIndex, maxVoteOptions]);