Merge pull request privacy-scaling-explorations#1423 from privacy-sca…

…ling-explorations/refactor/simplify-circuit

refactor(circuits): simplify generatePathIndices templates

circuits/circom/trees/incrementalMerkleTree.circom

@@ -124,22 +124,16 @@ template MerkleGeneratePathIndices(levels) {
 
     signal input in; 
     signal output out[levels];
-    signal n[levels + 1];
 
     var m = in;
     var computedResults[levels];
 
     for (var i = 0; i < levels; i++) {
         // circom's best practices suggests to avoid using <-- unless you
         // are aware of what's going on. This is the only way to do modulo operation.
-        n[i] <-- m;        
         out[i] <-- m % BASE;
         m = m \ BASE;
-    }
-
-    n[levels] <-- m;
 
-    for (var i = 0; i < levels; i++) {
         // Check that each output element is less than the base.
         var computedIsOutputElementLessThanBase = SafeLessThan(3)([out[i], BASE]);
         computedIsOutputElementLessThanBase === 1;

circuits/circom/trees/incrementalQuinaryTree.circom

@@ -199,22 +199,16 @@ template QuinGeneratePathIndices(levels) {
 
     signal input in; 
     signal output out[levels];
-    signal n[levels + 1];
 
     var m = in;
     var computedResults[levels];
 
     for (var i = 0; i < levels; i++) {
         // circom's best practices suggests to avoid using <-- unless you
         // are aware of what's going on. This is the only way to do modulo operation.
-        n[i] <-- m;        
         out[i] <-- m % BASE;
         m = m \ BASE;
-    }
-
-    n[levels] <-- m;
 
-    for (var i = 0; i < levels; i++) {
         // Check that each output element is less than the base.
         var computedIsOutputElementLessThanBase = SafeLessThan(3)([out[i], BASE]);
         computedIsOutputElementLessThanBase === 1;