Utility computation when: custom group sizes and columns in a group. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
servaasvdc
reviewed
Oct 30, 2019
channel_select.m
Outdated
Comment on lines
58
to
63
| case 'groupid' | ||
| grpid = Value; | ||
| nofuniq = unique(grpid); % Number of unique groups | ||
| if(size(grpid,1)~=size(A,2)) | ||
| error('Length of group-ids != No.of columns in A'); | ||
| end |
There was a problem hiding this comment.
Consider using inputParser for all this argument processing stuff
grputilcalc.m
Outdated
| % columns of data with each entry containing the group ID that the | ||
| % corresponding column in A belongs to. | ||
| function util = grputilcalc (RXXinv, W, grpid) | ||
|
|
There was a problem hiding this comment.
Have a look at https://nl.mathworks.com/help/matlab/matlab_prog/add-help-for-your-program.html for info on how to document a function. help grputilcalc will look probably look whack like this
There was a problem hiding this comment.
Apart from the formatting, some examples would be great as well. See also https://nl.mathworks.com/matlabcentral/fileexchange/46056-matlab-style-guidelines-2-0 -- great guide.
Comment on lines
+21
to
+29
| indx = (grpid==uniqgrps(k)); | ||
|
|
||
| % Select decoder weights of group k | ||
| Wkq = W(indx); | ||
|
|
||
| % utility computation of group k | ||
| S = RXXinv(indx,indx); | ||
|
|
||
| util(k) = Wkq'*(S\Wkq); |
There was a problem hiding this comment.
Looks okay but you could probably do this in a single line with splitapply, where grpid is the grouping variable
servaasvdc
reviewed
Nov 4, 2019
…channel-selection now in group-ID format
- Changed lambda selection to minimum positive eigen value; to match with the theory in paper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.