Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Manifest V3 #45

Closed
wants to merge 2 commits into from
Closed

Conversation

dominik-korsa
Copy link
Contributor

@dominik-korsa dominik-korsa commented Oct 27, 2024

  • Updated manifest.json to V3
  • Fixed use of moved browser.extension.getURL function
  • Replaced webRequest usage with declarativeNetRequest

These changes are enough to support Firefox, for Chrome support the background script must be converted to a service worker

@m4tx
Copy link
Owner

m4tx commented Oct 27, 2024

Oh, nice, thanks for this! I've started some work at https://github.com/m4tx/satori-enhancements/tree/oof-manifest-v3 as well (fortunately, as far as I can see, we've done pretty much non-overlapping stuff, so we should be able to easily merge this together).

I should have some time this week to complete this, unless you want to do it, in which case — just let me know and go ahead ;)

@m4tx
Copy link
Owner

m4tx commented Oct 30, 2024

It seems like most of the stuff is done now on the oof-manifest-v3 branch (incorporating your changes as well), i.e. the extension seems to be working just fine on Chromium. The remaining stuff is refactoring so we don't duplicate code between Chromium and Firefox (as we do now on said branch) and making sure it works 100%. I should be done with it by the end of today.

@m4tx
Copy link
Owner

m4tx commented Oct 30, 2024

Incorporated into #46, thanks for the contribution!

I'll issue a release soon — maybe I'll even try to send it to Firefox Add-ons again (it has been removed some time ago with "Due to the limited/non-public audience of this add-on, this add-on is not suitable for being listed").

@m4tx m4tx closed this Oct 30, 2024
@m4tx
Copy link
Owner

m4tx commented Oct 30, 2024

The 2.0 version is now available for Firefox on the Release page: https://github.com/m4tx/satori-enhancements/releases/tag/v2.0. It should be available in the Chrome Web Store soon as well, after it passes the review.

I've sent a request to the Firefox Add-ons reviewers about making it public again - we'll see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants