Simplified API for copying to/from page locked memory. #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
m4rs-mt
previously approved these changes
Nov 24, 2021
MoFtZ
force-pushed
the
feature/simplify-page-lock
branch
2 times, most recently
from
3e22676 to
9e35572
Compare
MoFtZ
force-pushed
the
feature/simplify-page-lock
branch
from
9e35572 to
a87266b
Compare
m4rs-mt
approved these changes
Aug 24, 2023
|
@MoFtZ looks like we have to address some conflicts before merging this feature. |
MoFtZ
force-pushed
the
feature/simplify-page-lock
branch
from
a87266b to
955aaee
Compare
m4rs-mt
reviewed
Sep 5, 2023
MoFtZ
force-pushed
the
feature/simplify-page-lock
branch
from
1a17bef to
d4563b5
Compare
m4rs-mt
approved these changes
Jan 8, 2024
m4rs-mt
force-pushed
the
feature/simplify-page-lock
branch
from
d4563b5 to
db43cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #691.
Removes the various CopyFrom/CopyToPageLockedAsync methods in favour of the more generic CopyTo/CopyFrom ArrayView methods. This allows copying to/from a subset of the page locked array without adding a lot of extra to methods specifically support it.
PageLockedScopednow exposes anArrayViewproperty that can be used to interact with the existing CopyFrom/CopyTo ArrayView methods.