Fixed NVVM generation for void functions and out parameters. #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoFtZ
force-pushed
the
bug/libdevice-nvvm
branch
from
6139ef5 to
043fb1e
Compare
MoFtZ
changed the title
MoFtZ
changed the title
m4rs-mt
approved these changes
Jan 12, 2024
MoFtZ
added a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 18, 2024
MoFtZ
added a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 18, 2024
MoFtZ
added a commit
to MoFtZ/ILGPU
that referenced
this pull request
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We pre-generate NVVM instructions at compile-time, to be used for generating PTX at runtime.
For LibDevice functions like
SinCosthat returnvoid, and haveoutparameters, we were generating the wrong NVVM instructions.We were incorrectly trying to store the result of a
voidfunction into a return variable. And foroutparameters, treating it like a normal variable, rather than a pointer to a variable.