Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Continuous index across disabling/enabling of earning #106

Open
wants to merge 1 commit into
base: feat/no-claim-on-transfer-2
Choose a base branch
from
Open

feat: Continuous index across disabling/enabling of earning #106

wants to merge 1 commit into from
+370 −180

Conversation

deluca-mike
Copy link
Collaborator

No description provided.

@deluca-mike deluca-mike added the enhancement New feature or request label Jan 23, 2025
@deluca-mike deluca-mike self-assigned this Jan 23, 2025
@github-actions GitHub Actions
Copy link

LCOV of commit c64dd91 during Forge Coverage #541

Summary coverage rate:
  lines......: 98.4% (248 of 252 lines)
  functions..: 98.2% (56 of 57 functions)
  branches...: 88.0% (22 of 25 branches)

Files changed coverage rate:
                       |Lines       |Functions  |Branches    
  Filename             |Rate     Num|Rate    Num|Rate     Num
  ===========================================================
  src/MigratorV1.sol   |20.0%     25|80.0%     5|    -      0
  src/WrappedMToken.sol|23.3%    223|41.2%    51|    -      0

PierrickGT
PierrickGT reviewed Jan 24, 2025
View reviewed changes
src/WrappedMToken.sol
}

/// @inheritdoc IWrappedMToken
function startEarningFor(address account_) external {
if (!isEarningEnabled()) revert EarningIsDisabled();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we still revert if earning is currently disabled?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierrickGT PierrickGT PierrickGT left review comments

@toninorair toninorair Awaiting requested review from toninorair

@0xIryna 0xIryna Awaiting requested review from 0xIryna

@Oighty Oighty Awaiting requested review from Oighty

Assignees

@deluca-mike deluca-mike

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deluca-mike @PierrickGT