Allows for each forum to select multiple webhooks. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, somehow I was not receiving notifications for this project, so I just took note of your PR right now. Thanks for implementing this, that's a nice feature! I need a few days to review and test it. |
|
After a first glance, I noticed that you did not create a new database migration but modified the existing one. This will break the extension for everyone updating and not doing a fresh install. Could you please create a new migration that migrates the existing configuration? That would be awesome, so everyone can upgrade smoothly. |
|
Thankyou for the review. I'll look into that soon. |
|
Letting you know I still intend to get to this, but my schedule has become more busy and I don't know when I will be able. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the ability to send data from the same forum to multiple channels in my discord server, so I decided to implement the changes to your extension.