Add missing clear statement and tests

lycheeverse · Aug 22, 2023 · f04d127 · f04d127
1 parent 2fb3466
commit f04d127
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 1 deletion.
diff --git a/lychee-lib/src/extract/html/html5ever.rs b/lychee-lib/src/extract/html/html5ever.rs
@@ -373,4 +373,14 @@ mod tests {
         let uris = extract_html(input, false);
         assert!(uris.is_empty());
     }
+
+    #[test]
+    fn test_skip_preconnect_reverse_order() {
+        let input = r#"
+            <link href="https://example.com" rel="preconnect">
+        "#;
+
+        let uris = extract_html(input, false);
+        assert!(uris.is_empty());
+    }
 }
diff --git a/lychee-lib/src/extract/html/html5gum.rs b/lychee-lib/src/extract/html/html5gum.rs
@@ -229,6 +229,7 @@ impl Emitter for &mut LinkExtractor {
         self.flush_current_characters();
         self.current_element_name.clear();
         self.current_element_nofollow = false;
+        self.current_element_preconnect = false;
         self.current_element_is_closing = false;
     }
 
@@ -404,7 +405,7 @@ mod tests {
     }
 
     #[test]
-    fn test_include_nofollow() {
+    fn test_exclude_nofollow() {
         let input = r#"
         <a rel="nofollow" href="https://foo.com">do not follow me</a>
         <a rel="canonical,nofollow,dns-prefetch" href="https://example.com">do not follow me</a>
@@ -419,6 +420,15 @@ mod tests {
         assert_eq!(uris, expected);
     }
 
+    #[test]
+    fn test_exclude_nofollow_change_order() {
+        let input = r#"
+        <a href="https://foo.com" rel="nofollow">do not follow me</a>
+        "#;
+        let uris = extract_html(input, false);
+        assert!(uris.is_empty());
+    }
+
     #[test]
     fn test_exclude_script_tags() {
         let input = r#"
@@ -528,4 +538,14 @@ mod tests {
         let uris = extract_html(input, false);
         assert!(uris.is_empty());
     }
+
+    #[test]
+    fn test_skip_preconnect_reverse_order() {
+        let input = r#"
+            <link href="https://example.com" rel="preconnect">
+        "#;
+
+        let uris = extract_html(input, false);
+        assert!(uris.is_empty());
+    }
 }