Initialize members in constructor

Thanks to clang-tidy.
lxqt · Jan 19, 2024 · 2f74dcf · 2f74dcf
1 parent e8a1aef
commit 2f74dcf
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 14 deletions.
diff --git a/src/bookmarkswidget.cpp b/src/bookmarkswidget.cpp
@@ -323,10 +323,10 @@ bool BookmarksModel::setData(const QModelIndex &index, const QVariant &value,
 
 BookmarksWidget::BookmarksWidget(QWidget *parent)
     : QWidget(parent)
+    , m_model(new BookmarksModel(this))
 {
     setupUi(this);
 
-    m_model = new BookmarksModel(this);
     treeView->setModel(m_model);
     treeView->header()->hide();
     setFocusProxy(filterEdit);

diff --git a/src/tab-switcher.cpp b/src/tab-switcher.cpp
@@ -89,15 +89,15 @@ class AppItemDelegate: public QStyledItemDelegate
 
 // -----------------------------------------------------------------------------------------------------------
 
-TabSwitcher::TabSwitcher(TabWidget* tabs):
-    QListView(tabs),
-    m_tabs(tabs)
+TabSwitcher::TabSwitcher(TabWidget *tabs)
+    : QListView(tabs)
+    , m_timer(new QTimer(this))
+    , m_tabs(tabs)
 {
     setWindowFlags(Qt::Widget | Qt::Popup | Qt::WindowStaysOnTopHint);
     setItemDelegate(new AppItemDelegate(frameWidth(), tabs));
     setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
 
-    m_timer = new QTimer(this);
     m_timer->setInterval(100);
     m_timer->setSingleShot(true);
 

diff --git a/src/terminalconfig.cpp b/src/terminalconfig.cpp
@@ -8,10 +8,10 @@
 #include "properties.h"
 #include "termwidget.h"
 
-TerminalConfig::TerminalConfig(const QString & wdir, const QStringList & shell)
+TerminalConfig::TerminalConfig(const QString &wdir, const QStringList &shell)
+    : m_workingDirectory(wdir)
+    , m_shell(shell)
 {
-    m_workingDirectory = wdir;
-    m_shell = shell;
 }
 
 TerminalConfig::TerminalConfig()

diff --git a/src/termwidget.cpp b/src/termwidget.cpp
@@ -268,19 +268,20 @@ bool TermWidget::eventFilter(QObject * /*obj*/, QEvent * ev)
     return false;
 }
 
-TermWidget::TermWidget(TerminalConfig &cfg, QWidget * parent)
-    : QWidget(parent),
-      DBusAddressable(QStringLiteral("/terminals"))
+TermWidget::TermWidget(TerminalConfig &cfg, QWidget *parent)
+    : QWidget(parent)
+    , DBusAddressable(QStringLiteral("/terminals"))
+    , m_term(new TermWidgetImpl(cfg, this))
+    , m_layout(new QVBoxLayout)
+    , m_border(palette().color(QPalette::Window))
 {
 
     #ifdef HAVE_QDBUS
     registerAdapter<TerminalAdaptor, TermWidget>(this);
     #endif
-    m_border = palette().color(QPalette::Window);
-    m_term = new TermWidgetImpl(cfg, this);
+
     setFocusProxy(m_term);
 
-    m_layout = new QVBoxLayout;
     setLayout(m_layout);
 
     m_layout->addWidget(m_term);