Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Qt6 port #2024

Merged
merged 34 commits into from
Mar 25, 2024
Merged

WIP Qt6 port #2024

merged 34 commits into from
Mar 25, 2024

Commits on Feb 11, 2024

  1. CMake: FindXCB components are upper case

    Fixes CMake error
    gfgit committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5dc5d82 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Configuration menu
    Copy the full SHA
    07f702a View commit details
    Browse the repository at this point in the history
  2. CMake: link to dbusmenu-lxqt instead of dbusmenu-qt6

    StatusNotifierButton: switch to dbusmenu-lxqt
    gfgit committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b4fe335 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96a6dc6 View commit details
    Browse the repository at this point in the history
  4. Replace QPair with std::pair

    gfgit committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bfcf78a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    61893fb View commit details
    Browse the repository at this point in the history
  6. QEvent: port pos() to position() and globalPos() to globalPosition()

    - Now returns floating point QPointF, should we keep
    it instead of rounding and do floating point calculations?
    gfgit committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    fb5c5c8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d1c1ce8 View commit details
    Browse the repository at this point in the history
  8. QLayou::setContentsMargin() instead of setMargin()

    - QEyesPlugin: remove deprecated setMargin() call
    gfgit committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    190280c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b8b33c6 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Configuration menu
    Copy the full SHA
    df2dbd6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    767279e View commit details
    Browse the repository at this point in the history
  3. Qt6 always enables High-DPI Pixmaps

    Qt::AA_UseHighDpiPixmaps has no effect now
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    be4ea20 View commit details
    Browse the repository at this point in the history
  4. Plugin: move Q_DECLARE_METATYPE()

    Fix error:
    static assertion failed: Pointer Meta Types must either point to
    fully-defined types or be declared with Q_DECLARE_OPAQUE_POINTER(T *)
    
    Q_DECLARE_METATYPE(...) must be used on fully qualified types
    To avoid including plugin.h inside panelpluginsmodel.h,
    the declaretion is moved.
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ed2ba12 View commit details
    Browse the repository at this point in the history
  5. Use QColor::fromString()

    setNamedColor() is deprecated in Qt6
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    62abb3b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    70b600d View commit details
    Browse the repository at this point in the history
  7. Disable ColorPicker on Wayland

    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    fd68007 View commit details
    Browse the repository at this point in the history
  8. Fix KX11Extras, KWindowSystem includes

    TODO: Still don't know why prefix does not work
    
    - Remove includes to QDesktopWidget
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4daeae7 View commit details
    Browse the repository at this point in the history
  9. Port QX11Info to QX11Application

    NOTE: Fix compilation with Xlib.h
    
    Xlib.h is tricky because at line 82 has:
    
    `#define Bool int`
    
    And QtCore/qjsonvalue.h at line 28 has:
    
    ```
    enum Type {
       ...
       Bool = 0x1,
       ...
    }
    ```
    
    This is fixed temporarily by moving Xlib.h
    include to last and undefine Bool macro
    
    Long term we want to hide X11 related code and encapsulate in a backend.
    This backend will not expose X11 headers.
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    0def137 View commit details
    Browse the repository at this point in the history
  10. LXQtTaskButton: port to KX11Extras

    Many X11 specific functions got moved away from KWindowSystem header.
    
    Long term we will move everything to a backend.
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    182f5c3 View commit details
    Browse the repository at this point in the history
  11. LXQtTaskButton: port away from QDesktopWidget

    Use QScreen instead
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    5ec5948 View commit details
    Browse the repository at this point in the history
  12. QString::arg(...) use mult-arg version

    Reported by Clazy
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    6a335eb View commit details
    Browse the repository at this point in the history
  13. LXQtCpuLoad: do not include <QtCore> directly

    Reported by Clazy
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ee5f859 View commit details
    Browse the repository at this point in the history
  14. Configuration: fix call to temporary object

    Teporary objects get destroyed after call ends.
    State is not updated.
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9135e8d View commit details
    Browse the repository at this point in the history
  15. QEyesConfigDialog: avoid allocating temporary container

    - Reported by Clazy
    - Also fix formatting a bit
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    498c29e View commit details
    Browse the repository at this point in the history
  16. QEyesImageWidget: unneeded QString allocation

    - Use Qt::CaseInsensitive instead
    - Pass argument by reference
    - Format braces
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    41fa69f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    b818989 View commit details
    Browse the repository at this point in the history
  18. Port LXQtTrayPlugin to Qt6

    NOTE: QX11Info::getTimestamp() was replaced with XCB_CURRENT_TIME macro.
    
    I don't know if this breaks functionality.
    Getting real timestamp involves messing with Qt private APIs
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    e16dd22 View commit details
    Browse the repository at this point in the history
  19. LXQtTaskBar: fix include recursion

    - Forward declare classes
    - More refactory could be done here
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    4349e2c View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    c1b37a8 View commit details
    Browse the repository at this point in the history
  21. Replace QScopedPointer with std::unique_ptr

    - Use Xcb::ScopedCPointer for POD types
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8b82354 View commit details
    Browse the repository at this point in the history
  22. Replace QVector with QList

    In Qt6 it's an alias
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    bc615d9 View commit details
    Browse the repository at this point in the history
  23. SNIProxy: use QBitmap::fromImage TODO

    TODO: is behavior equivalent? Conversion flags...
    gfgit committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    336f6b2 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    c7fd57d View commit details
    Browse the repository at this point in the history