Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxc-alpine: Improve integrity checking of static package manager #68

Merged
merged 4 commits into from
Dec 10, 2024
Merged

lxc-alpine: Improve integrity checking of static package manager #68

merged 4 commits into from
Dec 10, 2024

Conversation

kunkku
Copy link
Contributor

@kunkku kunkku commented Dec 10, 2024

This PR improves the integrity checking of the statically linked package manager executable (apk.static):

  • Do not crash when a SHA256 signature file is present.
  • Prefer the SHA256 signature to SHA1 when present.
  • Delete the file on verification failure (to prevent it from becoming the default APK executable on the next run).

@kunkku
lxc-alpine: variable for apk.static path
7c3b65b 
Signed-off-by: Kaarle Ritvanen <[email protected]>
@kunkku
lxc-alpine: more specific SHA1 sig file match
7ff9ef0 
that avoids matching the SHA256 file

Signed-off-by: Kaarle Ritvanen <[email protected]>
@kunkku
lxc-alpine: remove unverified apk.static
4908667 
to prevent its execution on the next run

Signed-off-by: Kaarle Ritvanen <[email protected]>
@kunkku
lxc-alpine: use SHA256 signature if available
f78b226 
to verify apk.static

Signed-off-by: Kaarle Ritvanen <[email protected]>
@stgraber stgraber merged commit da14466 into lxc:main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stgraber stgraber stgraber approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kunkku @stgraber