Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to geaaru/docker-companion fork and repair docker-http sourcer #888

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

geaaru
Copy link
Contributor

@geaaru geaaru commented Nov 13, 2024

This will add support to docker schema v2 on docker-http sourcer. The schema v1 seems no more supported by public Docker Hub.

Test:

$> sudo /home/geaaru/dev/distrobuilder/distrobuilder/distrobuilder build-incus  terragon-minimal-dev/image.yaml images/terragon-minimal-dev/20241113_11:52 --cache-dir /tmp/cachedir
INFO   [2024-11-13T23:24:14+01:00] Downloading source                           
2024/11/13 23:24:14 registry.ping url=https://registry-1.docker.io/v2/
2024/11/13 23:24:15 registry.manifest.get url=https://registry-1.docker.io/v2/macaronios/terragon-dev-minimal/manifests/latest-amd64 repository=macaronios/terragon-dev-minimal reference=latest-amd64
2024/11/13 23:24:16 registry.blob.download url=https://registry-1.docker.io/v2/macaronios/terragon-dev-minimal/blobs/sha256:bfe0ffb9541a327395ec88f9836c99522f7366db9d91def16c69fcec572639f8 repository=macaronios/terragon-dev-minimal digest=sha256:bfe0ffb9541a327395ec88f9836c99522f7366db9d91def16c69fcec572639f8
2024/11/13 23:24:17 registry.blob.download url=https://registry-1.docker.io/v2/macaronios/terragon-dev-minimal/blobs/sha256:057cb8f721385a72f1b5336b40ce7bb779f568222867c77132f89bd9b1138f75 repository=macaronios/terragon-dev-minimal digest=sha256:057cb8f721385a72f1b5336b40ce7bb779f568222867c77132f89bd9b1138f75
2024/11/13 23:24:17 registry.blob.download url=https://registry-1.docker.io/v2/macaronios/terragon-dev-minimal/blobs/sha256:a4236501c03c9250ebb141cda795d52ca7271041f7c467c476a790b1eaac2f89 repository=macaronios/terragon-dev-minimal digest=sha256:a4236501c03c9250ebb141cda795d52ca7271041f7c467c476a790b1eaac2f89
2024/11/13 23:24:18 registry.blob.download url=https://registry-1.docker.io/v2/macaronios/terragon-dev-minimal/blobs/sha256:07c31bcf61dc5c70896a727de423c6879734ab3a91faa64f6c934086c4efc12c repository=macaronios/terragon-dev-minimal digest=sha256:07c31bcf61dc5c70896a727de423c6879734ab3a91faa64f6c934086c4efc12c
2024/11/13 23:24:19 registry.blob.download url=https://registry-1.docker.io/v2/macaronios/terragon-dev-minimal/blobs/sha256:ccb00f0b582c7bf08cbe0b0a93b246039d51910ed771e75a4f9a3fa3eb622fa3 repository=macaronios/terragon-dev-minimal digest=sha256:ccb00f0b582c7bf08cbe0b0a93b246039d51910ed771e75a4f9a3fa3eb622fa3
2024/11/13 23:24:24 registry.blob.download url=https://registry-1.docker.io/v2/macaronios/terragon-dev-minimal/blobs/sha256:d8072a310984083896f5f63e43a6ba11710bd641211aa05a51781cabfe2d8246 repository=macaronios/terragon-dev-minimal digest=sha256:d8072a310984083896f5f63e43a6ba11710bd641211aa05a51781cabfe2d8246
INFO   [2024-11-13T23:24:30+01:00] Managing repositories                        
INFO   [2024-11-13T23:24:30+01:00] Running hooks                                 trigger=post-unpack
...

This could be show as a temporary fix that permit to have docker-http working again while will be fixed with a better solution using libraries yet maintained.

This will add support to docker schema v2
on `docker-http` sourcer. The schema v1
seems no more supported by public Docker Hub.

Signed-off-by: Daniele Rondina <[email protected]>
@geaaru
Copy link
Contributor Author

geaaru commented Nov 13, 2024

Add the error received before the fix:

Created directory images/terragon-minimal-dev/20241113_09:50 for image of the product macaroni-terragon-minimal-dev:current:amd64:default.
time="2024-11-13T09:50:39Z" level=info msg="Downloading source"
2024/11/13 09:50:39 registry.ping url=https://registry-1.docker.io/v2/
2024/11/13 09:50:40 registry.manifest.get url=https://registry-1.docker.io/v2/macaronios/terragon-dev-minimal/manifests/latest-amd64 repository=macaronios/terragon-dev-minimal reference=latest-amd64
ERROR 2024/11/13 09:50:41 missing signature key

@stgraber stgraber merged commit 7e71c93 into lxc:main Nov 14, 2024
7 of 8 checks passed
@geaaru geaaru deleted the fix-docker-source branch November 14, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants