dhcp: add support for MUD options (RFC 8520) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
dhcp-mud-options
branch
from
ffa77c2
to
655c6b1
Compare
|
Going through the code once more, I noticed and fixed a couple of issues – I think the PR should now be in a much more mergeable state. @yarrick, @goldsimon: Do you think it would be possible for you to give me some feedback on this PR? If you should approve the changes, I would resubmit the patches on GNU Savannah. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone :)
More than a year ago, I submitted a couple of patches (see https://savannah.nongnu.org/patch/?10265) to introduce support for the Manufacturer Usage Description (MUD, RFC 8520) to the DHCP(v6) clients.
As I got no response to the patches so far, I wanted to create this PR to potentially increase the chance that the patches get seen and reviewed. As there have been some changes in the upstream repository in the meantime, I rebased my development branch to create a clean diff. After a potential review, I could resubmit the patches over on Savannah.