Skip to content

Commit

Permalink
httpc with LWIP_HTTPC_HAVE_FILE_IO: fix heap buffer overflow for long…
Browse files Browse the repository at this point in the history
… local filenames

See bug #64940
  • Loading branch information
goldsimon committed Nov 29, 2023
1 parent 5e3268c commit ee15236
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/apps/http/http_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -734,12 +734,17 @@ httpc_fs_init(httpc_filestate_t **filestate_out, const char* local_file_name,
{
httpc_filestate_t *filestate;
size_t file_len, alloc_len;
mem_size_t alloc_mem_size;
FILE *f;

file_len = strlen(local_file_name);
alloc_len = sizeof(httpc_filestate_t) + file_len + 1;

filestate = (httpc_filestate_t *)mem_malloc((mem_size_t)alloc_len);
alloc_mem_size = (mem_size_t)alloc_len;
if (alloc_mem_size < alloc_len) {
/* overflow */
return ERR_MEM;
}
filestate = (httpc_filestate_t *)mem_malloc(alloc_mem_size);
if (filestate == NULL) {
return ERR_MEM;
}
Expand Down

0 comments on commit ee15236

Please sign in to comment.