Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Rails 7.2 #193

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Add support for Rails 7.2 #193

merged 4 commits into from
Aug 12, 2024

Conversation

n-rodriguez
Copy link
Contributor

Thank you!

@n-rodriguez
Copy link
Contributor Author

CI is green https://github.com/n-rodriguez/page_title_helper/actions/runs/10336525899

@oliverklee oliverklee self-requested a review August 12, 2024 09:29
@oliverklee oliverklee added feature new functionality dependencies Pull requests that update a dependency file labels Aug 12, 2024
oliverklee
oliverklee approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! ❤️

@oliverklee oliverklee merged commit 4606b1a into lwe:main Aug 12, 2024
13 checks passed
@oliverklee
Copy link
Collaborator

@n-rodriguez I've just released version 8.0.0 with your changes:
https://github.com/lwe/page_title_helper/releases/tag/v8.0.0

Thank you again for contributing! 🙏

@n-rodriguez
Copy link
Contributor Author

@oliverklee thank you!

@n-rodriguez n-rodriguez deleted the wip/rails_7.2 branch August 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@n-rodriguez n-rodriguez

Labels
dependencies Pull requests that update a dependency file feature new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-rodriguez @oliverklee