Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScummVM: adding support for command_args and adding game Maniac Mansion #1002

Merged
merged 3 commits into from
Sep 18, 2023

Conversation

Jpxe
Copy link
Contributor

@Jpxe Jpxe commented Sep 18, 2023

ScummVM: adding support for command_args and adding game Maniac Mansion.

Adding command arguments since I wanted specific options for Maniac Mansion.
Added maniac-v2 as the game ver to start, since it's the best ver.
Adding render-mode amiga since that looks better.

I've also tested it with Loom to check that it didn't break any other games and it worked fine.

New Engine Package Submissions

  • Have you followed the instructions in the build documentation?
  • Have you run the build locally and ensured the package allowed you to launch and play the Steam game?
  • Have you updated the packages.json file?
  • Have you ensured that there is not already a pull request or active engine package for the one you are adding?

Common Code Submissions

  • Have you verified that the changes are isolated to the features or fixes you are wanting to do?
  • Have you tested at least one of the engines to ensure that your changes do not break existing workflow?
  • Have you described what your changes are accomplishing?

@d10sfan
Copy link
Member

d10sfan commented Sep 18, 2023

Looks good thanks

@d10sfan d10sfan merged commit ac5e119 into luxtorpeda-dev:master Sep 18, 2023
1 of 2 checks passed
@Jpxe Jpxe deleted the ScummVM_changes branch September 19, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants