Make the calibration utility more user friendly - based on modular-calibration #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Optimization and trace levels introduced WIP * tweaked parameters and updated tracelevel
2 tasks
saching13
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
Overall LGTM. Tested on OAK-D with random calibration data. Works as expected.
Fails when it shows the OAK-D-Pro in the window with following
File "/Users/blackbird-m1/luxonis/depthai/calibrate.py", line 1236, in <module>
Main().run()
File "/Users/blackbird-m1/luxonis/depthai/calibrate.py", line 393, in __init__
for in_cam in self.board_config['cameras'].keys():
AttributeError: 'Main' object has no attribute 'board_config'
Good to merge on fixing the above.
|
Actually capability to run on already captured dataset is missing. Need to add that option back in before merging in. Add option to select calibrate on existing data. Include option to select the dataset folder path. |
…or mode (capture, process)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten features from #840 on top of the
modular-calibrationbranch.