Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved poe_set_ip.py script usage and reduced chance of errors. #1008

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ahrastnik
Copy link

@ahrastnik ahrastnik commented Apr 19, 2024

Improves the poe_set_ip.py example.

  • Added input validation
  • Added command for getting the currently set IP in order to verify it
  • Made it so the command can be run in one step, so it's easier to set multiple devices

@ahrastnik ahrastnik requested a review from Erol444 April 19, 2024 11:58
@ahrastnik ahrastnik self-assigned this Apr 19, 2024
@themarpe
Copy link
Collaborator

@Erol444 please review & merge if okay

@Erol444
Copy link
Member

Erol444 commented May 14, 2024

@ahrastnik Could we also update the docs for this example?
https://github.com/luxonis/depthai-python/blob/main/docs/source/samples/bootloader/poe_set_ip.rst
Just on how to use the script/args
Otherwise LGTM, works as expected

@ahrastnik ahrastnik removed their assignment May 15, 2024
@ahrastnik
Copy link
Author

@Erol444 done. I've also noticed there's a C++ version of the script. It would be best to get someone to update that too for the sake for completeness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants