Update 3Di driver to expose groundwater and surface water as individual meshes #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
approved these changes
Mar 19, 2024
There was a problem hiding this comment.
Looks good to me.
Please
- (optional) add few lines here: https://github.com/lutraconsulting/MDAL/blob/master/docs/source/drivers/3di.rst
- bump the MDAL version
- update https://github.com/lutraconsulting/MDAL?tab=readme-ov-file#versioning-and-integration-in-qgis
- create PR in QGIS
tests/test_3di.cpp
Outdated
| std::string path = test_file( "/3di/2d_groundwater/results_3di.nc" ); | ||
| EXPECT_EQ( MDAL_MeshNames( path.c_str() ), "3Di:\"" + path + "\":Mesh2D;;3Di:\"" + path + "\":Mesh2D_groundwater;;3Di:\"" + path + "\":Mesh2D_surface_water" ); | ||
| std::string uri = "3Di:\"" + path + "\":Mesh2D_groundwater"; | ||
| // std::string uri = "3Di:\"" + path + "\":Mesh2D"; |
tests/test_3di.cpp
Outdated
| std::string path = test_file( "/3di/2d_groundwater/results_3di.nc" ); | ||
| EXPECT_EQ( MDAL_MeshNames( path.c_str() ), "3Di:\"" + path + "\":Mesh2D;;3Di:\"" + path + "\":Mesh2D_groundwater;;3Di:\"" + path + "\":Mesh2D_surface_water" ); | ||
| std::string uri = "3Di:\"" + path + "\":Mesh2D_surface_water"; | ||
| // std::string uri = "3Di:\"" + path + "\":Mesh2D"; |
|
|
||
| private: | ||
| std::vector< size_t > mRequestedMeshFaceIds; | ||
| }; | ||
|
|
||
| /** | ||
| * Driver of 3Di file format. |
There was a problem hiding this comment.
can you add few lines about the 3 meshes we support
uclaros
force-pushed
the
3di-groundwater
branch
from
48619c7 to
04a97c6
Compare
|
Thanks for the review @PeterPetrik . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the 3Di driver, in addition to the existing
Mesh2Dmesh, the driver now allows to openMesh2D_groundwaterandMesh2D_surface_waterindividual meshesAlso fixes dataset min/max statistics which returned nan/nan, breaking the symbology in QGIS