Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: delegate issue for text element in xml #91

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

HassanAkbar
Copy link
Member

Fixing issue when using delegate option with custom models.

fix #57

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to update readme?

@ronaldtse ronaldtse merged commit ac6faaa into main Sep 19, 2024
13 of 14 checks passed
@HassanAkbar
Copy link
Member Author

Do we need to update readme?

@ronaldtse I think we don't need to update the readme.

This is the example that could have failed with custom model. So I think the readme already includes this.

  map_content to: :name_of_content, with: {
    to: :method_name_to_serialize,
    from: :method_name_to_deserialize
  }

@ronaldtse ronaldtse deleted the fixing_delegate_issue_in_text branch September 19, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(URGENT) Mixed content at root not working
2 participants