Auto-detect Ghostty and Konsole as supporting the Kitty protocol #24
Conversation
|
Can you share that you actually have the application running? We need to make sure that scrolling, opening details, etc. works properly and then add it to the list of supported terminals. https://github.com/lusingander/serie?tab=readme-ov-file#compatibility |
|
Here's with Ghostty. I'll remove Konsole since I can't verify it works there, was just adding it to the list of terminals that support the Kitty protocol specifically since that is verifiable. CleanShot.2024-08-02.at.08.41.19.mp4 |
|
I can verify Konsole works with this PR, see where
|
|
Oop awesome, I'll revert that bit of my last commit then! |
uncenter
changed the title
|
|
|
Thanks for checking, could you please share it on the Discussions? I've created a Discussions page where we can share how the terminal works. It also contains information that we would like to know. |
|
Once Konsole has been shared on the Discussions or removed from the changes, I will merge this. |
|
I already went out of my way to test Konsole. Not only does this PR properly detect it (which is the only aspect relevant to the PR in the first place) but while I had it installed and open I checked the visuals and usability and confirmed that it functions properly. I even posted a screen shot while I was at it. I'm not going back and record video, sorry—not sorry. Don't put undue burdens on the contribution process. Clearly what this PR does relevant to Konsole is correct. The terminal is already supported, this just detects which protocol to use as for other terminals which is better than not working at all unless people know to add an extra argument. |
|
Would love to get this merged - @lusingander are we alright with Konsole support as demonstrated by @alerque? |
Follow up of #23, as per my comment: #10 (comment).