Use Map for rule search and add benchmark #334
+253
−750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the changes proposed by @gugu's in #302 as well as on other minor tweaks (like only iterating over the rules once instead of twice on module load).
This increases performance (ops/sec) by a factor of over 100!!
The main change is using a
Map
object and indexing it bypunySuffix
. This allows searching bypunySuffix
without having to iterate over the thousands of rules.