-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Runtime::run
Return Lua Values
#178
Conversation
`Runtime::run` now returns a tuple of both the `ExitCode` (denoting whether the lua thread generally succeeded or not) and also the values returned by it.
This commit removes the chained unwraps introduced previously with a match statement which handles the case when a lua thread may return no values.
@filiptibell In order to return consumable exit information, I'll go ahead and create an issue in the repo. |
I'm currently returning the raw exit code, instead of an |
I know this is out of the scope of this current PRs, but these minor clippy warnings have been a bit annoying to look at lately, so I've gone ahead and fixed them! :)
Just a heads up - since this is a breaking change it's going to take a while before it gets merged. I've added it to the |
Would it be possible to merge this before #188? |
Guess I will restructure once the restructuring is complete. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this! Everything looks good to me 👍
This PR intends to return a more meaningful output for
Runtime::run
invocations. Instead of only returning anExitCode
,Runtime::run
now returns a tuple including aVec
of values returned by the lua thread.TODO:
u8
instead ofExitCode
mlua-luau-scheduler#1 to be mergedOnce merged, this closes #175 and closes #92.