Use correct tuple ordering in resolve_paths #171
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After noticing that the test in #170 failed, and after some inspection in a debugger, I discovered some incorrectness around the
RequireContext::resolve_paths
method. This method returns a tuple(rel_path, abs_path)
, but the caller seems to expect(abs_path, rel_path)
:lune/src/lune/globals/require/context.rs
Lines 56 to 74 in 94ba331
lune/src/lune/globals/require/path.rs
Line 16 in 94ba331
This PR closes #138 by swapping the order of the tuple fields in
RequireContext::resolve_paths
to match the rest of the code.