Fix stack overflow caused by tables with cyclic references #158
Conversation
There was a problem hiding this comment.
I see this only handles direct self references (one level up, one parent) but it's a lot better than our current behavior (crashing) so LGTM 👍 we can expand on it later.
For the future: it would probably be good to refactor this to not be recursive, and do something like give ids to tables and print them out as <table 1> <table 2> etc since a single <self> for all tables (even if they aren't the same table) is very opaque and may be difficult to figure out for a user.
|
Agree! Would you mind fixing the CI (if it's trivial), kind of triggering me a bit lol. |
I don't have a windows machine unfortunately and previous attempts haven't worked out 😕 but yeah would be nice to get fixed |
|
Could try my hand at that then, will lyk if I can fix it up. |
Minor changes which include handling of cyclic tables.
Closes #156.