Use TerrainMaterials::from_str to parse material variant name #118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
FromStr
implementation was added toTerrainMaterials
in rbx_dom_weak 2.6.0. This PR removes thematerial_from_name
function and changesTerrain:GetMaterialColor
andTerrain:SetMaterialColor
to use this newFromStr
implementation to parse material variants from enum names. This reduces the amount of code in the terrain module and gives the responsibility of knowing all valid terrain materials to rbx-dom.