CI Windows tests fix

[SnorlaxAssist]

This PR solves a sub issue of #107.

I’ve made some changes to the process/spawn.luau test file, and the rust process/options.rs to improve support for Windows. Default shell process for windows has been changed to powershell instead of /bin/sh. These changes ensure that the tests can run smoothly across different operating systems by using commands that have equivalent or similar functionality in Unix and Windows based OS.

[SnorlaxAssist]

Made test changes that fixes tests::net_serve_requests errors on Windows.

[CompeyDev]

This looks great! Out of curiosity, what was causing net tests to fail (i.e., the server not stopping)?

EDIT: Looked at the changes, and that answered my question.

EDIT 2: I believe a lot of the windows testing logic can be simplified, as most of it is due to lack of GNU command line equivalents on Windows.

Here is proposed solution, try this on your local machine, and lmk if that fixes the serde compression issues.

[SnorlaxAssist]

Serde passes all test on my machine, I am using windows 11. Although in a virtual machine serde doesn't pass the test, I'm not exactly sure why but I'm more leaning to what @filiptibell said about files being checked out using CRLF instead of LF.

Edit: I can confirm CRLF was the issue, a fix was made in the test file. Although the issue could also be fixed within fs.readFile, I'm not too sure how my PC didn't pick up on this, likely due to some installs I have or maybe even WSL.

[CompeyDev]

Edit: I can confirm CRLF was the issue, a fix was made in the test file. Although the issue could also be fixed within fs.readFile, I'm not too sure how my PC didn't pick up on this, likely due to some installs I have or maybe even WSL.

What exactly is the issue in fs.readFile? I'd PR this if it was feasible.

[CompeyDev]

Btw, 1cf7e9b is not really making use of the MinGW installation, you'd also need to change the target being compiled for.

https://github.com/filiptibell/lune/blob/1cf7e9b7fd01cae1184374f6a0c2c44ca982f01d/.github/workflows/ci.yaml#L39

This should be x86_64-pc-windows-gnu, and should build successfully if MinGW is properly setup in the install step.

[filiptibell]

Hi and thank you for the PR! I left a few minor comments.

RE: Using mingw and sticking with unix-y commands on Windows, I've been thinking on it a bit, and I think the main thing is someone downloading the repo for the first time on Windows should have all the tests pass without any additional configuration on their end. We should try to use system defaults like Powershell when possible in tests. We could have gone with cmd.exe too, like Node does, but that feels quite outdated.

[SnorlaxAssist]

Hopefully this is the last commit, there is one slight issue maybe that could be a problem in the future, where MacOS process spawn test fails with Spawning a sleep process should take a reasonable amount of time it seems to run slightly longer just by a little than the SLEEP_DURATION * 1.5.

A possible fix can be to increase the 1.5x to 2x or 2.5x.

[filiptibell]

LGTM! The timing issue on macOS is fine to leave out of this PR since it is addressing Windows issues after all. Thanks for getting this all fixed. Sorry about the commit noise - GitHub didn't want to do a merge commit so I had to rebase instead. It will all get squashed anyway.